Fix Clippy in shredding part 1:#4
Open
alamb wants to merge 1 commit intocmu-db:shredding-variant-part1from
Open
Fix Clippy in shredding part 1:#4alamb wants to merge 1 commit intocmu-db:shredding-variant-part1from
alamb wants to merge 1 commit intocmu-db:shredding-variant-part1from
Conversation
alamb
commented
Sep 4, 2025
alamb
commented
- Merging this PR will update [Variant] Support Shredded Objects in variant_get apache/arrow-rs#8166 in arrow-rs
alamb
force-pushed
the
shredding-variant-part1
branch
from
4d3cbde to
61bca91
Compare
alamb
commented
Sep 5, 2025
| // Create nested structure: {"a": {"x": 55}, "b": 42} | ||
| let mut obj = builder.new_object(); | ||
| obj.insert("a", a_variant); | ||
| let mut a_obj = obj.new_object("x"); |
Author
There was a problem hiding this comment.
the API for making nested structures appears to have changed, so I updated the tests to use the new API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.